ZEPPELIN-467 Fix ace editor focusing problem in chrome#482
Closed
Leemoonsoo wants to merge 2 commits into
Closed
Conversation
Member
Author
|
Ready to merge |
Member
There was a problem hiding this comment.
@Leemoonsoo avoid using angular.element('body') multiple times. better to have it in a var and reuse.
Leemoonsoo
force-pushed
the
ZEPPELIN-467
branch
from
9f34165 to
04ba168
Compare
Member
Author
|
@r-kamath removed repeating code. |
Member
|
👍 LGTM. works well on Chrome and Firefox |
Member
Author
|
Thanks @r-kamath for review. |
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Nov 30, 2015
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-467 When (invisible) textarea position is not correctly placed(this problem occur in Chrome when contents in editor is long), place it in cursor position of ace editor. not always set to 0. This PR also includes scrolling animation improvement. Make animation faster (duration 200 -> 100ms), and cancel animation before new animation starts. Author: Lee moon soo <moon@apache.org> Closes apache#482 from Leemoonsoo/ZEPPELIN-467 and squashes the following commits: 434b5b2 [Lee moon soo] Avoid repeating angular.element('body') 04ba168 [Lee moon soo] Fix ace editor focusing problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-467
When (invisible) textarea position is not correctly placed(this problem occur in Chrome when contents in editor is long), place it in cursor position of ace editor. not always set to 0.
This PR also includes scrolling animation improvement. Make animation faster (duration 200 -> 100ms), and cancel animation before new animation starts.