[ZEPPELIN-474] Provide InterpreterContext as ThreadLocal value#492
Closed
Leemoonsoo wants to merge 2 commits into
Closed
[ZEPPELIN-474] Provide InterpreterContext as ThreadLocal value#492Leemoonsoo wants to merge 2 commits into
Leemoonsoo wants to merge 2 commits into
Conversation
Member
There was a problem hiding this comment.
Would it be too big change to make InterpreterContext a singleton, and then add non-static field of the TreadLocal?
Member
Author
There was a problem hiding this comment.
I'm not sure if i understand your suggestion correctly, but InterpreterContext is created every time. For example, every single call, new instance of InterpreterContext is created passed into Interpreter.interpret() method. So i think it's hard to make InterpreterContext a singleton.
Member
There was a problem hiding this comment.
You are right, thank your for the explanation!
Member
|
Looks good to me |
Member
Author
|
I'm merging it into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements ZEPPELIN-474.
Let 3rd party library access InterpreterContext.