Fix dead link and add table tab to Zeppelin Configuration section: docs/install/install.md#679
Fix dead link and add table tab to Zeppelin Configuration section: docs/install/install.md#679AhyoungRyu wants to merge 8 commits into
Conversation
|
The tabs are nice but would it be better to put -env.sh in a column, -site.xml in another in one table? They have a lot overlap? |
|
@felixcheung You're right. |
|
Thanks @AhyoungRyu for the improvement. But I also think seeing environment variable and property in one table together is much easier to discover necessary configuration. |
|
@Leemoonsoo I see. So I applied your comment and pushed it : ) |
There was a problem hiding this comment.
extra space in "from Zeppelin"
|
@felixcheung |
There was a problem hiding this comment.
In this documentation, we will guide you how you can install
-> In this documentation, we will explain how you can install
Plus, you can get a specific infomation about Zeppelin configurations at the below Zeppelin Configuration section
-> Plus, you can see all of Zeppelin's configurations in the Zeppelin Configuration section below.
There was a problem hiding this comment.
Thank you for the review @corneadoug : )
I applied your comments and pushed again.
|
Except for that last comment, LGTM! |
|
@corneadoug Thanks. I applied it : ) |
|
Merging if there is no more discussions |
What is this PR for?
As mentioned at ZEPPELIN-638, there is a dead link in
docs/install/install.md. So I fixed it. Plus, I also add a table tab to Zeppelin Configuration section because current one is not good to look.What type of PR is it?
Improvement | Documentation
Todos
Is there a relevant Jira issue?
ZEPPELIN-638 (only for fixing dead link)
How should this be tested?
After applying this PR, you can check this page
Quick Start->Installat Zeppelin documentation.Screenshots (if appropriate)
Questions: