Skip to content

2617 wicketstuff.bs4#505

Merged
andi-huber merged 57 commits intomasterfrom
2617_wicketstuff.bs4
Apr 27, 2021
Merged

2617 wicketstuff.bs4#505
andi-huber merged 57 commits intomasterfrom
2617_wicketstuff.bs4

Conversation

@andi-huber
Copy link
Contributor

@andi-huber andi-huber commented Apr 20, 2021 •
edited
Loading

  • 1. Table style dropdown
  • 2. Action Dropdown
  • 3. Trees
  • 4. Right Label Position (also broken in M5 - so no worries) [WON'T FIX]
  • 5. Disabled Actions (strange style)
  • 6. Where's the default Flatly color gone?
  • 7. Table Paging Support
  • 8. DateTime picker on empty field, has the browser interfere using autocompletion (seen on firefox)
  • 9. Responsive design behavior of main menu got lost (partly fixed but not production ready)
  • 10. Reasess ISIS-2390
  • 11. Menu item labels have wrong mouse over cursor style, but only some, not all - these which are 'defect' also render in a stronger foreground color
  • 12. Bookmark links are inactive, cannot click on these (when there's only a single bookmark)
  • 13. Tertiary menu has a different base-line
  • 14. Title fontsize too large (minor)
  • 15. Bookmark color should be same as theme foreground (minor) [WON'T FIX]
  • 16. Mouse Over Drop Down is gone (Main menu and Theme Select)
  • 17. Action Drop Down should have consistent styling (font) with Menu Drop Down
  • 18. Menus: Mouse over Tooltip has the menu lose focus then it goes hiding. (no issues with firefox, but issues with chrome)
  • 19. Menus: Disabled Menu Items should render visually distinguishable (grey), also having cursor style 'disabled'
  • 20. Missing mouse over auto drop-down behavior on Action Drop Downs
  • 21. With a line-wrapped menu-bar, we have 'menu going into hiding' issues again
  • 22. Maybe we can get rid of CSS magic #body{ padding-top: 61px; }, as it is inconsistent with menu-bar line wrapping support
  • 23. Menu-bar disappears on vertical scroll
  • 24. Dropdown menu auto open will not work for elements of the DOM that are added via AJAX (eg. Tabs?)
  • 25. When clicking an action button that has a popover (i.e. to edit a text field) then the popover doesn't automatically close
  • 26. Bookmark ribbon has too much vertical size
  • 27. Menu-bar brand-Icon (as of sticky-top fix) dictates the navbar height; maybe we find a consistent way to have the menu-bar a little smaller regarding vertical size

This change is Reviewable

mwhesse and others added 13 commits April 20, 2021 20:08
@mwhesse @andi-huber
Upgrading boostrap from version 3 to 4 (WIP)
d5db478
@mwhesse @andi-huber
Adding dropdown-item class to menu links
6c2393d
@mwhesse @andi-huber
Adjusting card bottom margin, adding new sizes
9e49f32
@mwhesse @andi-huber
Reworking clearfix show/hide
f565250
@mwhesse @andi-huber
Adapting footer to BS4
1c0f4d0
@mwhesse @andi-huber
Adapting secondary and tertiary header menu, removing all occurences …
6c70fad 
…of .panel-default
@mwhesse @andi-huber
Excluding popper.js through wicket-bootstrap-core
070f377
@mwhesse @andi-huber
Removing all occurences of inline CSS styles
40a46f4
@mwhesse @andi-huber
Adapting bookmarks panel, themechooser, removing occurences of xs-bre…
0b63b05 
…akpoints, fixing missing popper.js dependency
@mwhesse @andi-huber
Adding setting to enable jQuery V3 in wicket
25e5c1a
@mwhesse @andi-huber
Extending popover config with boundary (fixes flickering or flipping …
a61d54c 
…entity link popovers in collections)
@andi-huber
ISIS-2617: bump wicket 8.11->8.12
190ae8b
@andi-huber
ISIS-2617: minor config polishing; use jQuery 3.x as default
b80c341
@andi-huber andi-huber force-pushed the 2617_wicketstuff.bs4 branch from b5105cc to a8936ff Compare April 20, 2021 18:13
@andi-huber andi-huber self-assigned this Apr 22, 2021
andi-huber added 13 commits April 26, 2021 14:03
@andi-huber
ISIS-2617: fixes menu going into hiding (more robust popup detection)
7fed901
@andi-huber
ISIS-2617: CSS fix for disabled menu-items
2b696de 
assuming grey foreground text color is reasonable to apply to light as
well as dark themes
@andi-huber
ISIS-2617: menu-bar: distinguished rendering for selected menu items
d6943f7 
assuming white-ish background overlay color is reasonable to apply to
light as well as dark themes
@andi-huber
ISIS-2617: CSS fix for disabled buttons
1b7b6c7
@andi-huber
ISIS-2617: change nav-bar responsive design from navbar-expand-xl to
fe89f55 
navbar-expand-sm

also use lighter bg color for footer

also fixing footer height
@andi-huber
ISIS-2617: allow primary menu to wrap (fixes responsive design behavior)
04bf962
@andi-huber
ISIS-2617: CSS fix for menu going hiding when menu-bar is line-wrapped
2963506
@andi-huber
ISIS-2617: CSS fix: allow footer to line-wrap
a40cf4f
@andi-huber
ISIS-2617: disables open menu on hover behavior for collapsed menu-bar
c89e1ba
@andi-huber
ISIS-2617: do not disable bookmark links
633e65a
@andi-huber
ISIS-2617: use auto open on hover for additional action drop-down
8fa083b 
also remove the mouse leave hack - turns out we don't need it
@andi-huber
ISIS-2617: cleaning up some comments
89bbfee
@andi-huber
ISIS-2617: fixes auto open on hover for additional action drop-down
021c44c
@andi-huber andi-huber force-pushed the 2617_wicketstuff.bs4 branch from bf03d1c to 021c44c Compare April 26, 2021 17:57
andi-huber added 13 commits April 26, 2021 20:16
@andi-huber
ISIS-2617: fixes action drop-down style
8455f82
@andi-huber
ISIS-2617: remove CSS hack #body{ padding-top: 61px; }
3a351b2
@andi-huber
Merge remote-tracking branch 'origin/master' into 2617_wicketstuff.bs4
29ca74d
@andi-huber
ISIS-2617: fixes vertical scroll hides menu-bar
406d4ed 
adds class name 'sticky-top' to the navbar; the navbar element must be a
direct child of <body>
@andi-huber
ISIS-2617: replace bookmark ribbon with a fa icon (fixed size, fixed
7830a76 
position, consistent colors)
@andi-huber
ISIS-2617: fixes navbar brand icon not vertically aligned middle
1dc91f6
@andi-huber
ISIS-2617: polishing: set menu collapse at <768px
4677cbf
@andi-huber
ISIS-2617: polishing: replace style attributes with proper CSS class
943054c
@andi-huber
ISIS-2617: remove bookmark ribbon height js hack
23b817e
@andi-huber
ISIS-2617: polishing: make bookmark ribbon slightly larger
388e1c1
@andi-huber
ISIS-2617: fixes dropup menu going hiding when mouse pointer falls into
bbda96b 
the gap between button and dropup
@andi-huber
ISIS-2617: fixes disabled menu items too light on darkly theme
ae73e12
@andi-huber
ISIS-2617: disable additional-action-links auto open
6dad902 
as it currently does not work consistently eg. with AJAX requests
@andi-huber andi-huber marked this pull request as ready for review April 27, 2021 12:12
@andi-huber andi-huber merged commit ce52691 into master Apr 27, 2021
@andi-huber andi-huber deleted the 2617_wicketstuff.bs4 branch April 27, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwhesse mwhesse mwhesse approved these changes

Assignees

@andi-huber andi-huber

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andi-huber @mwhesse