Isis 2619 : sorts out fixtures for secman#529
Merged
danhaywood merged 5 commits intomasterfrom May 14, 2021
Merged
Conversation
Also: - introduces NAMESPACE and OBJECT_TYPE constants as required - uses FQCN for secman entity 'FROM' clauses - removes fixtureRoleName from secman config bean (no point discerned) - adds comments for usage of Secman config bean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To minimize duplication, adds constants for OBJECT_ONLY and NAMESPACE and uses them if possible
Also takes advantage of updated 'associateWith' and new 'choicesFrom' where nec, for the secman mixins.
Finally, also improves javadoc for secman's config bean, and removes the fixtureRoleName that was unnecessary (its default namespace permissions were incorrect, and its purpose superceded by the new set of more targetted seed scripts).