-
Notifications
You must be signed in to change notification settings - Fork 485
Mailbox 211 : distributed event systems #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rely on composition rather than on inheritance for capabilities extension - Generalise it so that working on on the event system will be easier - Rely on well tested Guava stuff instead of hand craffted collections
…sandra based implementation
…based implementation
Contributor
Author
|
I updated the PR after Matthieu comments. It still needs to be unit test validated ( will take ~ an hour ). |
asfgit
pushed a commit
that referenced
this pull request
Apr 22, 2020
It should not be set implicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I propose 3 kind of event system :
Note that the on going discussion about Message Sequence Number handling via the event system is still an open debate ;-)