-
Notifications
You must be signed in to change notification settings - Fork 677
[GH-1719]: Move from webpack to Vite #1718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "@vue/cli-plugin-eslint": "~5.0.8", | ||
| "@vue/cli-plugin-unit-mocha": "~5.0.8", | ||
| "@vue/cli-service": "~5.0.8", | ||
| "@vitejs/plugin-vue": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less dependencies as Vite does many of what these other tools do (and has been adopted by devs doing Vue, React, Angular, ThreeJS, so now it's stable and future-prone too 🤞 )
| import Menu from '@/components/dataset/Menu.vue' | ||
| import FileUpload from 'vue-upload-component' | ||
| import JenaTable from '@/components/dataset/JenaTable' | ||
| import JenaTable from '@/components/dataset/JenaTable.vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vite does not handle the extension of imports. So we need to specify it.
| "sass-loader": "^13.0.2", | ||
| "sinon": "^14.0.0", | ||
| "vite": "^4.0.4", | ||
| "vitest": "^0.27.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vitest is recommended in Vue3 docs https://vuejs.org/guide/scaling-up/testing.html#unit-testing
| "express": "^4.18.1", | ||
| "istanbul-instrumenter-loader": "^3.0.1", | ||
| "istanbul-lib-coverage": "^3.2.0", | ||
| "jsdom": "^21.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For vitest/tests.
| "@vue/eslint-config-standard": "^8.0.1", | ||
| "@vue/test-utils": "^2.0.2", | ||
| "babel-plugin-istanbul": "^6.1.1", | ||
| "chai": "^4.3.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vitest has assertions. No need for chai anymore.
| }, | ||
| "devDependencies": { | ||
| "@babel/eslint-parser": "^7.19.1", | ||
| "@babel/register": "^7.18.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be fine dropping support to older browsers (IE, older Ffox, Chrome... Ffox and Chrome have supported newer JS for years now, nobody should be using IE... this reduces our build time & size - makes UI/JS development a lot easier too).
27169ec to
d250c0f
Compare
|
Do you want to create an issue for this? (which can be auto-closed by the PR). An issue is a little more findable and can pull together several work items if necessary. |
Sure thing. Consider it done. What about |
4deac5e to
a1482e3
Compare
|
We haven't been using issues for the site. They aren't enabled. This lighter weight process has been OK for contributions as far as I can see. The code issues for the release description. |
|
Work is all done, and apparently Fuseki UI is running with no major problems. I'm having a problem to dynamically control the coverage in e2e tests, but no other issues. Just pending to do some tests with Fuseki servlets, and get the numbers from |
|
Done. Build should be a bit faster now 👍 |
|
It's faster! I get the old error after 2 clean runs - with more information about where: First: |
Hooray! And we will have less direct dependencies to worry (not sure about number of transitive deps).
Hmmmm... I wonder if the tests are running before the fake Fuseki is up and serving. I think I can simulate a very slow startup to confirm if the Cypress process is waiting on the fake Fuseki ( Thanks @afs! Merging. |

GitHub issue resolved #1719
Pull request Description:
Moving from webpack to Vite for faster build, simpler configuration, faster dev server, and build.
Good refs:
Time on
main:Time after this change:
No extra tests to include. I did some manual testing from Eclipse with the code generated with Vite, and ran several times the commands. Cypress has been updated from 10 to 12. Maybe that brittle test has been fixed too 🤞
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.