Feature/jspwiki 1198 plugin api change, discovery and in browser auto complete snippets #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyhunter99
added
the
review requested
spyhunter99
commented
Nov 15, 2025
jspwiki-test-plugin/src/main/java/org/apache/jspwiki/jspwiki/test/plugin/JspwikiTestPlugin.java
Outdated
Show resolved
Hide resolved
…r code cleanup update the api change to include localization support updates all existing plugins to use the new api methods JSPWIKI-1242 fix for the web blog snippet being incorrect
…tion menu is localized.
Contributor
juanpablo-santos
left a comment
juanpablo-santos
left a comment
There was a problem hiding this comment.
Hi! personally, I like this very much! I've placed a few nitpicks, but overall idea is great
jspwiki-main/src/test/java/org/apache/wiki/ui/admin/beans/PluginBeanTest.java
Outdated
Show resolved
Hide resolved
… which will display it in the browser now
juanpablo-santos
approved these changes
Nov 16, 2025
Contributor
juanpablo-santos
left a comment
juanpablo-santos
left a comment
There was a problem hiding this comment.
lgtm now - thanks :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.