Skip to content

Conversation

swebb2066
Copy link
Contributor

This PR provides an option for LOG4CXX_XXXXX_FMT_ASYNC macros when Log4cxx is build with fmt::fmt as a dependency

@rm5248
Copy link
Contributor

rm5248 commented Oct 12, 2025

For the other macros, we have the ability to use either std::format or fmt::format just by changing the namespace. Is that possible with this as well?

@swebb2066
Copy link
Contributor Author

Is that possible with this as well?

No . The standard library has no equivalent to fmt::dynamic_format_arg_store

@rm5248
Copy link
Contributor

rm5248 commented Oct 13, 2025

Is that possible with this as well?

No . The standard library has no equivalent to fmt::dynamic_format_arg_store

I haven't had a chance to try this out yet, but there is std::make_format_args which may be able to be used here.

@swebb2066
Copy link
Contributor Author

swebb2066 commented Oct 13, 2025

is std::make_format_args which may be able to be used here

The notes section indicates it is not an option

A formatting argument has reference semantics for user-defined types and does not extend the lifetime of args. It is the programmer's responsibility to ensure that args outlive the return value

@swebb2066 swebb2066 merged commit 08c83f5 into master Oct 13, 2025
37 of 38 checks passed
@swebb2066 swebb2066 deleted the async_fmt_macros branch October 13, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants