Skip to content

Conversation

@joycebrum
Copy link
Contributor

@joycebrum joycebrum commented Feb 27, 2023

Changes

Closes #1289

  • Set codeql workflo top level permission as read-all, according to other workflows' top level permissions.

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise

    I've based on release-2.x since basing on 2.x was causing some conflict on CONTRIBUTING.md. Let me know if I should base on 2.xanyway

  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run spotless:apply and retry)
  • Changes contain an entry file in the src/changelog/.2.x.x directory

    Is it also applicable to this type of changes (on the workflows)?

  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

Signed-off-by: Joyce Brum <joycebrum@google.com>
@vy vy deleted the branch apache:release-2.x February 28, 2023 15:03
@vy vy closed this Feb 28, 2023
@ppkarwasz
Copy link
Contributor

@joycebrum,

This was closed automatically by Github because we renamed the release-2.x branch to 2.x. Feel free to resubmit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set permissions to codeql github workflow

3 participants