Skip to content

Fix NPE caused by MDCContextMap #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fix NPE caused by MDCContextMap #2115

merged 2 commits into from
Dec 21, 2023

Conversation

@ppkarwasz
Copy link
Contributor

@ppkarwasz ppkarwasz commented Dec 20, 2023 •
edited
Loading

Fixes an NPE caused by MDCContextMap: the MDC#getCopyOfContextMap method can return null, but ThreadContextMap#getCopy can not return null.

Closes #1426

@ppkarwasz
Fix NPE in RollingFileManger
95a90e0 
This PR fixes a `NullPointerException` in
`RollingFileManager#createParentDir`.

Closes apache#1645
@ppkarwasz
Fix NPE caused by MDCContextMap
4e107c0
@ppkarwasz ppkarwasz force-pushed the 1426-npe-in-closeablethreadcontext branch from 611f417 to 4e107c0 Compare December 21, 2023 13:05
@ppkarwasz ppkarwasz merged commit 4e107c0 into apache:2.x Dec 21, 2023
@ppkarwasz ppkarwasz deleted the 1426-npe-in-closeablethreadcontext branch December 21, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MDCContextMap::getCopy can return null causing an NPE in CloseableThreadContext

1 participant

@ppkarwasz