LOG4J-2676: Backport use of javax.annotation.processing.Messager to release-2.x. #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elease-2.x. Add a test for Bazel support for the PluginProcessor, which does not work on 2.12.1 due to System.out calls, but works with this PR.
jvz
requested changes
Sep 3, 2019
Member
There was a problem hiding this comment.
Do you know of any way this can read the project version from the pom.xml instead of using a hard-coded version number in the file names? Also, if you can use bazel to build and run a unit test, you could make a fairly minimal one to verify that the plugin is initialized by the config.
Also, if you rebase from release-2.x, you should get a working Travis config (I think).
Member
|
I understand the desire to get rid of System.out calls but why is bazel being added? |
Member
|
I committed the change without the bazel stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for Bazel support for the PluginProcessor, which does not work on 2.12.1 due to System.out calls, but works with this PR.