Follow-up on maven.compiler.* properties change #550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
added a commit
to gnodet/maven-parent
that referenced
this pull request
Nov 13, 2025
Defining maven.compiler.source and maven.compiler.target properties when running on JDK >= 9 has some side effects. Fixes apache#503 Follow-up to apache/maven-apache-parent#543 and apache/maven-apache-parent#550
Member
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
I will prepare a simplifier proposition
Member
|
suppressed by #551 |
slawekjaranowski
added a commit
to apache/maven-parent
that referenced
this pull request
Nov 15, 2025
* Enhance target JDK definition for JDK >= 1 Defining maven.compiler.source and maven.compiler.target properties when running on JDK >= 9 has some side effects. Fixes #503 Follow-up to apache/maven-apache-parent#543 and apache/maven-apache-parent#550 * use javaVersion property --------- Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #543