Remove the integration test for MCOMPILER-346 #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was testing a workaround for an issue which was fixed in Java 15. Since Maven 4 requires Java 17 or later, workaround is not needed anymore (unless toolchains or forked compilers are used). Furthermore, the actual fix was in Plexus Compiler, which is not used anymore by the Maven plugin. Finally, the test was expecting a build failure with an error message that tends to vary between different versions of Maven Core, because the errors seem to be sometime detected earlier during dependencies collection. apache#554
cstamas
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCOMPILER-346 (#554) was testing a workaround for an issue which was fixed in Java 15. Since Maven 4 requires Java 17 or later, workaround is not needed anymore (unless toolchains or forked compilers are used). Furthermore, the actual fix was in Plexus Compiler, which is not used anymore by the Maven plugin. Finally, the test was expecting a build failure with an error message that tends to vary between different versions of Maven Core, because the errors seem to be sometime detected earlier during dependencies collection.