Be gracious with "filtering" of binary files #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects have among the test resources various binary files along with property files that actually need to be filtered. The binary files can be for instance dummy P12 or JKS files. When the pom.xml has filtering enabled for those resources, the parser tries to parse them as text files with the given encoding. But they are more then likely not to be valid UTF-8 or ISO-8859-1, ... files. An MalformedInputException is thrown in that case.
This fix catches that exception if it is thrown and, in that case, assumes that the file is a binary and copies it without filtering.
The included test will fail without the fix and pass with the fix