Skip to content

HTTP compression support in Java Http Client #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

HTTP compression support in Java Http Client #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a383b
Add test for HTTP compression support
kwin Oct 10, 2025
3489304
Use Methanol for support of response compression
kwin Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...st-http/src/main/java/org/eclipse/aether/internal/test/util/http/HttpTransporterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ protected void setUp(TestInfo testInfo) throws Exception {
factory = transporterFactorySupplier.get();
repoDir = TestFileUtils.createTempDir();
TestFileUtils.writeString(new File(repoDir, "file.txt"), "test");
TestFileUtils.writeString(new File(repoDir, "artifact.pom"), "<xml>pom</xml>");
TestFileUtils.writeString(new File(repoDir, "dir/file.txt"), "test");
TestFileUtils.writeString(new File(repoDir, "dir/oldFile.txt"), "oldTest", OLD_FILE_TIMESTAMP);
TestFileUtils.writeString(new File(repoDir, "empty.txt"), "");
Expand Down Expand Up @@ -391,6 +392,17 @@ protected void testGet_ToFileTimestamp() throws Exception {
assertEquals(OLD_FILE_TIMESTAMP, file.lastModified());
}

@Test
protected void testGet_CompressionUsedWithPom() throws Exception {
File file = TestFileUtils.createTempFile("pom");
GetTask task = new GetTask(URI.create("repo/artifact.pom")).setDataPath(file.toPath());
transporter.get(task);
String acceptEncoding = httpServer.getLogEntries().get(0).getHeaders().get("Accept-Encoding");
assertNotNull(acceptEncoding, "Missing Accept-Encoding header when retrieving pom");
// support either gzip or deflate as the transporter implementation may vary
assertTrue(acceptEncoding.contains("gzip") || acceptEncoding.contains("deflate"));
}

@Test
protected void testGet_EmptyResource() throws Exception {
File file = TestFileUtils.createTempFile("failure");
Expand Down
5 changes: 5 additions & 0 deletions maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-util</artifactId>
</dependency>
<dependency>
<groupId>com.github.mizosoft.methanol</groupId>
<artifactId>methanol</artifactId>
<version>1.8.3</version>
</dependency>
<dependency>
<groupId>javax.inject</groupId>
<artifactId>javax.inject</artifactId>
Expand Down
3 changes: 2 additions & 1 deletion ...olver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
import java.util.function.Supplier;
import java.util.regex.Matcher;

import com.github.mizosoft.methanol.Methanol;
import org.eclipse.aether.ConfigurationProperties;
import org.eclipse.aether.RepositorySystemSession;
import org.eclipse.aether.repository.AuthenticationContext;
Expand Down Expand Up @@ -485,7 +486,7 @@ public X509Certificate[] getAcceptedIssuers() {
}
}

HttpClient.Builder builder = HttpClient.newBuilder()
HttpClient.Builder builder = Methanol.newBuilder()
.version(HttpClient.Version.valueOf(ConfigUtils.getString(
session,
DEFAULT_HTTP_VERSION,
Expand Down