Skip to content

[1.9.x] Mild backport: support same properties as Resolver 2.x #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2025
Merged

[1.9.x] Mild backport: support same properties as Resolver 2.x #1656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b7f533
Mild backport: support same properties as Resolver 2.x
cstamas Nov 14, 2025
5f06dad
Fix, missing negation
cstamas Nov 14, 2025
fe4a34e
Merge remote-tracking branch 'upstream/maven-resolver-1.9.x' into mav…
cstamas Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...in/java/org/eclipse/aether/internal/impl/filter/DefaultRemoteRepositoryFilterManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ public DefaultRemoteRepositoryFilterManager(Map<String, RemoteRepositoryFilterSo

@Override
public RemoteRepositoryFilter getRemoteRepositoryFilter(RepositorySystemSession session) {
return (RemoteRepositoryFilter) session.getData().computeIfAbsent(INSTANCE_KEY, () -> {
// use session specific key to distinguish between "derived" sessions
String instanceSpecificKey = INSTANCE_KEY + "." + session.hashCode();
return (RemoteRepositoryFilter) session.getData().computeIfAbsent(instanceSpecificKey, () -> {
HashMap<String, RemoteRepositoryFilter> filters = new HashMap<>();
for (Map.Entry<String, RemoteRepositoryFilterSource> entry : sources.entrySet()) {
RemoteRepositoryFilter filter = entry.getValue().getRemoteRepositoryFilter(session);
Expand Down
3 changes: 2 additions & 1 deletion ...ain/java/org/eclipse/aether/internal/impl/filter/RemoteRepositoryFilterSourceSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ protected String configPropKey(String name) {
* Default is {@code false}.
*/
protected boolean isEnabled(RepositorySystemSession session) {
return ConfigUtils.getBoolean(session, false, CONFIG_PROP_PREFIX + this.name);
return ConfigUtils.getBoolean(session, false, CONFIG_PROP_PREFIX + this.name)
&& !ConfigUtils.getBoolean(session, false, CONFIG_PROP_PREFIX + this.name + ".skipped");
}

/**
Expand Down