[1.9.x] Ability to use assymetric lock times #1671
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use assymetric lock times, and losers should not become serialized, so introduce yet another loop after attempt of exclusive lock. This improves runtime of reproducer too, as middle tasks are now able to run in parallel.
cstamas
changed the title
Member
Author
|
Not doing this. 1.9.25 is fine as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use assymetric lock times, and losers should not become serialized, so introduce yet another loop after attempt of exclusive lock. Worst scenario is still "overlapping artifacts" like in reproducer, but in all other case this allows losers to run in parallel.
This improves runtime of reproducer too, as "middle tasks" are now able to run in parallel (runtime lowered significantly, but not below 70%).
Note: investigate effect of this change to
installexecution path, as it also use exclusive locks (but not juggle with shared and exclusive like Artifact and Metadata resolver). User reports were only about ArtifactResolver.