Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Nov 18, 2025

Cleanup name mappers usage and introduce new, more selective mapper GAECV.

Changes:

  • introduce GAECV next to existing GAV name mapper.
  • make default GAECV

Cleanup name mappers usage and introduce new, more selective
mapper GAECV.
@cstamas cstamas self-assigned this Nov 18, 2025
@cstamas cstamas added the enhancement New feature or request label Nov 18, 2025
@cstamas cstamas added this to the 1.9.25 milestone Nov 18, 2025
@cstamas cstamas marked this pull request as ready for review November 18, 2025 12:19
@cstamas cstamas changed the title [1.9.x] Name mappers cleanup [1.9.x] Name mappers cleanup and new GAECV mapper Nov 18, 2025
return gavNameMapper(false);
}

public static NameMapper gavNameMapper(boolean fileSystemFriendly) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing @since

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@gnodet
Copy link
Contributor

gnodet commented Nov 18, 2025

Cleanup name mappers usage and introduce new, more selective mapper GAECV.

Changes:

  • introduce GAECV next to existing GAV name mapper.
  • make default GAECV

So we're diminishing lock contentions at the cost of acquiring more locks, right ?

@cstamas
Copy link
Member Author

cstamas commented Nov 18, 2025

So we're diminishing lock contentions at the cost of acquiring more locks, right ?

Yes, client code of SyncContext still asks for same number of artifacts/metadata, but existing GAV name mapper coalesced them into GAV-only. But IMO it is worth it (unless we see something down the road; but then we just need to swap back the default one in adapter), as so far we locked "whole GAV" even if some classifier was needed only, hurting badly concurrency.

@cstamas cstamas merged commit c1a8e85 into apache:maven-resolver-1.9.x Nov 18, 2025
16 of 17 checks passed
@cstamas cstamas deleted the maven-resolver-1.9.x-name-mapper-cleanup branch November 18, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants