-
Notifications
You must be signed in to change notification settings - Fork 140
[1.9.x] Name mappers cleanup and new GAECV mapper #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.9.x] Name mappers cleanup and new GAECV mapper #1674
Conversation
Cleanup name mappers usage and introduce new, more selective mapper GAECV.
| return gavNameMapper(false); | ||
| } | ||
|
|
||
| public static NameMapper gavNameMapper(boolean fileSystemFriendly) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing @since
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
So we're diminishing lock contentions at the cost of acquiring more locks, right ? |
Yes, client code of SyncContext still asks for same number of artifacts/metadata, but existing GAV name mapper coalesced them into GAV-only. But IMO it is worth it (unless we see something down the road; but then we just need to swap back the default one in adapter), as so far we locked "whole GAV" even if some classifier was needed only, hurting badly concurrency. |
Cleanup name mappers usage and introduce new, more selective mapper GAECV.
Changes: