Battery - Optional Start Delay #1555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccollins476ad
requested changes
Dec 7, 2018
There was a problem hiding this comment.
The code looks good to me. The only issue is that this changes a public API. The Mynewt release policy requires some amount of heads up to the community before such a change is made (https://cwiki.apache.org/confluence/display/MYNEWT/Release+and+Support+Policy#ReleaseandSupportPolicy-BackwardsCompatibility).
It might be easiest to sidestep this issue by adding a second function instead. Something like battery_set_poll_rate_ms_delay() or battery_next_run_delay() (the latter could just update b_next_run).
…in fuel guages necessary bootup time.
brolan-juul
force-pushed
the
fuel_guage_delay
branch
from
f2044dd to
4197d59
Compare
|
I just created a function for battery_set_poll_rate_ms_delay() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an extra parameter to potentially delay the first event.