-
Notifications
You must be signed in to change notification settings - Fork 533
Update maven selection tutorial #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, thanks for your effort I do some polish in the wiki, to deal with space and numbered list you should prefers + and not using [start] the numbers should be good by the wiki processor not by you/me hacking. Extract of a working part of another wiki page netbeans-antora-tutorials/modules/ROOT/pages/kb/docs/java/annotations-custom.adoc Lines 324 to 355 in 1b49d5f
If you prefer more gap for image, it would be more css related, and should be looked for all tutorials |
|
I fixed the format a bit, mostly |
probably a good choice to add a 0, otherwise it would collide with the other numbers at some point. |
That's a bit of a stretch buuuut it doesn't hurt, done |
I am sorry but you misunderstood. You already had the 0 in "270". I only meant to say that I think its ok to use the maven versioning scheme here too, given that we have ancient files in the same folder using "73". So I think "27" would be fine (possibly better) but "270" is good too since we probably could get rid of the old screenshots at some point. Super sorry to cause confusion. |
Now that makes sense! lol no problem, quick fix done. I also checked and all images except one could be safely deleted :) I just pushed those changes |
mbien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reads good!
|
@juanotto if you are happy with this PR, you could add the once done we can merge this update |
|
@juanotto , thanks for doing this.. |
|
@mbien done, with some hiccups but done... next one will be easier :) |

Draft while I try to get some space after the images... when through asciidoctor and antora docs, tried
+,{blank},{empty}, blank lines, lines with spaces...New versions of the images on the tutorial are added, using the same naming pattern most images follow:
_270_to indicate RELEASE270 was used.I added 1 new image because the handling of adding new modules is different than in the "Module Suites" era in which the original was written.
Some wording replaced (e.g. Module Suite with Application).
Some images are slightly blurry, better than the previous ones but still... I will try and fix that to actually try to merge this with the 2 parts selection tutorial part1 & part2. In the future :)