Fix invalid element references during completion resolution using ElementHandle which has additional text edits #9005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crashes and incorrect behavior when resolving completion items across different javac contexts.
When completion items are created, they capture Element references from the initial javac context. Later, when the LSP client calls
completionItem/resolveto fetchadditionalTextEdits, a new javac context may be used (especially if the file was modified). The old Element instances are invalid in the new context, causingAssertion Error rootPackage missing!; currModule: java.base.So, store ElementHandles instead of stale Elements when creating completion items.
Thanks @lahodaj for helping out.