Skip to content

Commit 119f81f

Browse files
davids5patacongo
authored andcommitted
Revert "Avoid calling ARCHIVE in multiple places"
This reverts commit 52222cb.
1 parent 9a28ccf commit 119f81f

File tree

3 files changed

+8
-26
lines changed

3 files changed

+8
-26
lines changed

Application.mk

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,12 @@ $(CXXOBJS): %$(SUFFIX)$(OBJEXT): %$(CXXEXT)
129129
$(call ELFCOMPILEXX, $<, $@), $(call COMPILEXX, $<, $@))
130130

131131
.built: $(OBJS)
132+
ifeq ($(WINTOOL),y)
133+
$(call ARCHIVE, "${shell cygpath -w $(BIN)}", $(OBJS))
134+
else
135+
$(call ARCHIVE, $(BIN), $(OBJS))
136+
endif
137+
$(Q) touch $@
132138

133139
ifeq ($(BUILD_MODULE),y)
134140

@@ -157,9 +163,6 @@ endif
157163

158164
install:: $(PROGLIST)
159165

160-
show-objs:
161-
@echo ""
162-
163166
else
164167

165168
MAINNAME := $(addsuffix _main,$(PROGNAME))
@@ -182,9 +185,6 @@ endif
182185

183186
install::
184187

185-
show-objs:
186-
@echo $(addprefix $(CWD)$(DELIM),$(OBJS))
187-
188188
endif # BUILD_MODULE
189189

190190
preconfig::

Directory.mk

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ $(foreach SDIR, $(SUBDIRS), $(eval $(call SDIR_template,$(SDIR),context)))
5454
$(foreach SDIR, $(SUBDIRS), $(eval $(call SDIR_template,$(SDIR),depend)))
5555
$(foreach SDIR, $(SUBDIRS), $(eval $(call SDIR_template,$(SDIR),clean)))
5656
$(foreach SDIR, $(SUBDIRS), $(eval $(call SDIR_template,$(SDIR),distclean)))
57-
$(foreach SDIR, $(SUBDIRS), $(eval $(call SDIR_template,$(SDIR),show-objs)))
5857

5958
nothing:
6059

@@ -76,6 +75,4 @@ ifneq ($(MENUDESC),)
7675
$(call DELFILE, Kconfig)
7776
endif
7877

79-
show-objs: $(foreach SDIR, $(SUBDIRS), $(SDIR)_show-objs)
80-
8178
-include Make.dep

Makefile

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ endif
5555
SYMTABSRC = symtab_apps.c
5656
SYMTABOBJ = $(SYMTABSRC:.c=$(OBJEXT))
5757

58-
APPOBJS = $(shell $(MAKE) show-objs TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)")
59-
6058
# Build targets
6159

6260
all: $(BIN)
@@ -68,11 +66,6 @@ define MAKE_template
6866

6967
endef
7068

71-
define MAKE_template_quiet
72-
@ $(MAKE) -C $(1) $(2) TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)" V=0 Q=@
73-
74-
endef
75-
7669
define SDIR_template
7770
$(1)_$(2):
7871
+$(Q) $(MAKE) -C $(1) $(2) TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)"
@@ -112,11 +105,6 @@ else
112105
ifeq ($(CONFIG_BUILD_LOADABLE),)
113106

114107
$(BIN): $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all)
115-
ifeq ($(WINTOOL),y)
116-
$(call ARCHIVE, "${shell cygpath -w $(BIN)}", $(APPOBJS))
117-
else
118-
$(call ARCHIVE, $(BIN), $(APPOBJS))
119-
endif
120108

121109
else
122110

@@ -129,9 +117,9 @@ $(SYMTABOBJ): %$(OBJEXT): %.c
129117

130118
$(BIN): $(SYMTABOBJ)
131119
ifeq ($(WINTOOL),y)
132-
$(call ARCHIVE, "${shell cygpath -w $(BIN)}", $(APPOBJS) $(SYMTABOBJ))
120+
$(call ARCHIVE, "${shell cygpath -w $(BIN)}", $^)
133121
else
134-
$(call ARCHIVE, $(BIN), $(APPOBJS) $(SYMTABOBJ))
122+
$(call ARCHIVE, $(BIN), $^)
135123
endif
136124

137125
endif # !CONFIG_BUILD_LOADABLE
@@ -167,9 +155,6 @@ Kconfig:
167155

168156
preconfig: Kconfig
169157

170-
show-objs:
171-
$(foreach SDIR, $(CONFIGURED_APPS), $(call MAKE_template_quiet,$(SDIR),show-objs))
172-
173158
export:
174159
ifneq ($(EXPORTDIR),)
175160
ifneq ($(BUILTIN_REGISTRY),)

0 commit comments

Comments
 (0)