add signal decouple support #3217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Networking
Area: System
Area: Testing
Area: NSH
Size: M
labels
extinguish
force-pushed
the
apps_signal_decouple
branch
from
fc21c7e to
9845726
Compare
1. sigprocmask_test/sighand_test/signest_test/suspend_test: these testcases are using to test the signal api 2. sigev_thread_test: this testcase need to access signal related function 3. timer_test: this testcase need to access signal related function Signed-off-by: guoshichao <guoshichao@xiaomi.com>
make the nsh tools can work with SIGNAL disabled Signed-off-by: guoshichao <guoshichao@xiaomi.com>
using pthread_cancel to implement the exit logic, thus to make the netutils tools can work when signal disabled Signed-off-by: guoshichao <guoshichao@xiaomi.com>
using the local cu_globals_s instance to manange the cu exit procedure Signed-off-by: guoshichao <guoshichao@xiaomi.com>
merge the cu.h to cu_main.c, to make the cu tools code more cleaner Signed-off-by: guoshichao <guoshichao@xiaomi.com>
The core functionality of the cu tool does not rely on signal features. Therefore, we can isolate the signal-related implementations to ensure that most functions of the cu tool remain operational even when signals are disabled. Signed-off-by: guoshichao <guoshichao@xiaomi.com>
extinguish
force-pushed
the
apps_signal_decouple
branch
from
9845726 to
67dd5d2
Compare
The commit 'add support for CONFIG_DISABLE_SIGNALS' led to: undefined reference to `signal' undefined reference to `sigaction' Signed-off-by: v-tangmeng <v-tangmeng@xiaomi.com>
…GNALS The commit 'add support for CONFIG_DISABLE_SIGNALS' led to: undefined reference to `sigaction' Signed-off-by: v-tangmeng <v-tangmeng@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for signal decoupling, primarily involving modifications to the following modules in the apps: ostest, nsh/tools, netutils, and the cu tool.
CONFIG_DISABLE_SIGNALS=y, certain tests that rely on signal functionality need to be disabled.CONFIG_DISABLE_SIGNALS=y.Impact
No adjustments were made to the functional logic; support was only added for when
CONFIG_DISABLE_SIGNALS=y.Testing