Skip to content

Conversation

@xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 commented Aug 1, 2021

Summary

follow other libc component naming convention

Impact

Follow up the kernel change: apache/nuttx#4267

Testing

Pass CI.

@xiaoxiang781216 xiaoxiang781216 changed the title Rename LIB_KBDCODEC to LIBC_KBDCODEC Rename LIB_ to LIBC_ for all libc Kconfig Aug 1, 2021
follow other libc component naming convention

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Copy link
Contributor

@gustavonihei gustavonihei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ouss4 Ouss4 merged commit 967f526 into apache:master Aug 5, 2021
@xiaoxiang781216 xiaoxiang781216 deleted the kbdcodec branch August 5, 2021 14:44
@acassis
Copy link
Contributor

acassis commented Aug 5, 2021

Seams like it broke the elf example:

elf_main.c: In function 'elf_main':
Error: elf_main.c:347:40: error: 'MOUNTPT' undeclared (first use in this function)
  347 |       snprintf(fullpath, 128, "%s/%s", MOUNTPT, dirlist[i]);
      |                                        ^~~~~~~
elf_main.c:347:40: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [/github/workspace/sources/apps/Application.mk:192: elf_main.c.github.workspace.sources.apps.examples.elf.o] Error 1

@acassis
Copy link
Contributor

acassis commented Aug 5, 2021

All board profile needs to be updated: CONFIG_LIB_ENVPATH -> CONFIG_LIBC_ENVPATH

@xiaoxiang781216
Copy link
Contributor Author

Yes, apache/nuttx#4267 should fixe this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants