Feature/dark mode support--solved issue #148 #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2025 22:18
- Download all 32 GitHub avatars to static/images/community/avatars/ - Update community-members.md template to use /static/images/community/avatars/ paths - Fixes Content Security Policy violations that blocked GitHub hotlinks - Images now load from same domain instead of external GitHub URLs
- Implement CSS custom properties for theming - Add theme toggle button in navigation - Add persistent theme preference storage - Support system preference detection - Ensure responsive design and accessibility
cederom
requested changes
Nov 26, 2025
Contributor
There was a problem hiding this comment.
Thanks @siddhitripathi25 :-)
- There are too many changes bundled into this PR.
- PR must only contain single functional change as described by the PR title.
- There are Gemfile.lock changes that I provided in a separate PR already, that impact build, and cannot be bundled here, this is not theme related.
- There are avatars changes in this PR, these were already provided before, cannot be part of this PR.
- Out Contributing Guidelines provides a lot of hints please take a look at https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md.
xiaoxiang781216
approved these changes
Nov 26, 2025
Contributor
|
@xiaoxiang781216 please review in detail and see my remarks thanks :-) |
Author
|
@cederom Thank you for the detailed feedback! I understand the issues with my PR. I'll: I appreciate you taking the time to guide me on the proper contribution process. |
Contributor
|
Please update this PR when ready. You can keep it in a draft state until ready for review. |
Author
|
@cederom Okay sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Solved issue #148
-@cederom @acassis
Description
This PR adds comprehensive dark mode support to the NuttX website, improving user experience and accessibility.
Changes Made
_sass/custom/_themes.scssprefers-color-scheme)Features
Files Modified
_sass/custom/_themes.scss- CSS variables for theming_sass/_base.scss- Updated to use theme variables_sass/_layout.scss- Updated to use theme variables_includes/themes/apache/_navigation.html- Added theme toggle button_includes/themes/apache/default.html- Added theme JavaScript and CSSassets/js/theme.js- Theme switching logiccss/main.scss- Import themesTesting
Screenshots
Light Mode:
Dark Mode:
