OPENJPA-2725 - fix ConcurrentModificationException during unrefed dependents cleanup #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eran-levy
changed the title
ilgrosso
reviewed
Jan 3, 2018
| // mark for delete all elements in deref, otherwise in some situations it | ||
| // throws ConcurrentModificationException | ||
| statesMarkedForDelete.addAll(_derefCache); | ||
| if(statesMarkedForDelete.size()>0) { |
Member
There was a problem hiding this comment.
This if can be safely removed: the subsequent foreach will skip in case of empty set
Member
|
Comment to link to OPENJPA-2725 |
Author
|
Fixed based on ilgrosso review |
gmarseglia
added a commit
to gmarseglia/openjpa_isw2
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations there are state elements in _derefCache HashSet causing ConcurrentModificationException because set has been modified during iteration.
Copy all elements into another set and calling the same deleteDeref(StateManagerImpl sm) function.