Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-4280. Document notable configurations for Recon. #1448

Merged
merged 1 commit into from
Oct 5, 2020
Merged

HDDS-4280. Document notable configurations for Recon. #1448

merged 1 commit into from
Oct 5, 2020

Conversation

linyiqun
Copy link
Contributor

@linyiqun linyiqun commented Sep 26, 2020 •
edited
Loading

What changes were proposed in this pull request?

Document notable configurations for Recon

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4280

How was this patch tested?

Github branch build test.

@vivekratnavel
Copy link
Contributor

@adoroszlai Thanks for working on this!

avijayanhwx
avijayanhwx approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@avijayanhwx avijayanhwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @linyiqun.

Can we add a follow up JIRA to fix this inconsistent config key (recon.om.snapshot.task.interval.delay) ?

@adoroszlai
Copy link
Contributor

Can we add a follow up JIRA to fix this inconsistent config key (recon.om.snapshot.task.interval.delay) ?

@avijayanhwx if you mean it should be prefixed with ozone., please note there are few other similar keys:

hadoop-hdds/common/src/main/resources/ozone-default.xml
2318:    <name>recon.om.connection.request.timeout</name>
2327:    <name>recon.om.connection.timeout</name>
2336:    <name>recon.om.socket.timeout</name>
2345:    <name>recon.om.snapshot.task.initial.delay</name>
2353:    <name>recon.om.snapshot.task.interval.delay</name>
2361:    <name>recon.om.snapshot.task.flush.param</name>

@linyiqun
Copy link
Contributor Author

linyiqun commented Oct 2, 2020

Can we add a follow up JIRA to fix this inconsistent config key (recon.om.snapshot.task.interval.delay) ?

Hi @avijayanhwx , I also find there is more other ozone recon keys not prefixed with ozone like @adoroszlai mentioned. Maybe we should fix them all in a separate JIRA.

@avijayanhwx
Copy link
Contributor

Can we add a follow up JIRA to fix this inconsistent config key (recon.om.snapshot.task.interval.delay) ?

Hi @avijayanhwx , I also find there is more other ozone recon keys not prefixed with ozone like @adoroszlai mentioned. Maybe we should fix them all in a separate JIRA.

Yes, @linyiqun I did not mean that config key name changes are related to your fix. I just noticed that bad name, and wanted to track it. I will create the JIRA myself.

@avijayanhwx
Copy link
Contributor

Thanks for the review @vivekratnavel.

@avijayanhwx avijayanhwx merged commit b6efb95 into apache:master Oct 5, 2020
@linyiqun
Copy link
Contributor Author

linyiqun commented Oct 6, 2020

Thanks @vivekratnavel and @avijayanhwx for the review and merge!

errose28 pushed a commit to errose28/ozone that referenced this pull request Oct 6, 2020
@linyiqun @errose28
HDDS-4280. Document notable configurations for Recon. (apache#1448)
9f2c53d
errose28 added a commit to errose28/ozone that referenced this pull request Oct 14, 2020
@errose28
Merge branch 'master' into HDDS-4123
7100ff7 
* master: (23 commits)
  HDDS-4122. Implement OM Delete Expired Open Key Request and Response (apache#1435)
  HDDS-4336. ContainerInfo does not persist BCSID (sequenceId) leading to failed replica reports (apache#1488)
  Remove extra serialization from getBlockID (apache#1470)
  HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests (apache#1436)
  HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens() (apache#1454)
  HDDS-4312. findbugs check succeeds despite compile error (apache#1476)
  HDDS-4311. Type-safe config design doc points to OM HA (apache#1477)
  HDDS-3814. Drop a column family through debug cli tool (apache#1083)
  HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block. (apache#1458)
  HDDS-4316. Upgrade to angular 1.8.0 due to CVE-2020-7676 (apache#1481)
  HDDS-4325. Incompatible return codes from Ozone getconf -confKey (apache#1485). Contributed by Doroszlai, Attila.
  HDDS-4309. Fix inconsistency in recon config keys starting with recon and not ozone (apache#1478)
  HDDS-4310: Ozone getconf broke the compatibility (apache#1475)
  HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager (apache#1460)
  HDDS-4280. Document notable configurations for Recon. (apache#1448)
  HDDS-4156. add hierarchical layout to Chinese doc (apache#1368)
  HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage (apache#1444)
  HDDS-4264. Uniform naming conventions of Ozone Shell Options. (apache#1447)
  HDDS-4271. Avoid logging chunk content in Ozone Insight (apache#1466)
  HDDS-4299. Display Ratis version with ozone version (apache#1464)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekratnavel vivekratnavel vivekratnavel approved these changes

@avijayanhwx avijayanhwx avijayanhwx approved these changes

@swagle swagle Awaiting requested review from swagle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@linyiqun @vivekratnavel @adoroszlai @avijayanhwx