Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4312. findbugs check succeeds despite compile error #1476

Merged
merged 3 commits into from
Oct 9, 2020

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  1. Make findbugs check correctly report compilation failure via exit code
  2. Compile test classes, required by test-jar dependency
  3. Exclude Protobuf generated classes in new hadoop-ozone/interface-storage module

https://issues.apache.org/jira/browse/HDDS-4312

How was this patch tested?

  1. Verified that findbugs check can now fail (without fixes 2 and 3)
  2. Verified that the check proceeds beyond compilation, and finds actual findbugs violations (without fix 3)
  3. Verified that findbugs check passes (with all 3 fixes)

@adoroszlai adoroszlai self-assigned this Oct 6, 2020
@adoroszlai adoroszlai changed the title HDDS-4312. findbugs check succeeds despite failure HDDS-4312. findbugs check succeeds despite compile error Oct 6, 2020
@adoroszlai adoroszlai added bug Something isn't working build Pull request that modifies the build process labels Oct 7, 2020
@adoroszlai adoroszlai requested a review from elek October 7, 2020 18:11
@adoroszlai
Copy link
Contributor Author

@amaliujia item 3 is related to HDDS-4242.

@amaliujia
Copy link
Contributor

amaliujia commented Oct 7, 2020

LGTM

@adoroszlai so for creating a new module that generates proto, the changes in this PR seems required. Will apply such change in the future when I create new modules.

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks the fix @adoroszlai

@elek elek merged commit 5c5d8cb into apache:master Oct 9, 2020
@adoroszlai adoroszlai deleted the HDDS-4312 branch October 9, 2020 21:27
@adoroszlai
Copy link
Contributor Author

Thanks @elek for reviewing and committing it, and @amaliujia for the review.

errose28 added a commit to errose28/ozone that referenced this pull request Oct 14, 2020
* master: (23 commits)
  HDDS-4122. Implement OM Delete Expired Open Key Request and Response (apache#1435)
  HDDS-4336. ContainerInfo does not persist BCSID (sequenceId) leading to failed replica reports (apache#1488)
  Remove extra serialization from getBlockID (apache#1470)
  HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests (apache#1436)
  HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens() (apache#1454)
  HDDS-4312. findbugs check succeeds despite compile error (apache#1476)
  HDDS-4311. Type-safe config design doc points to OM HA (apache#1477)
  HDDS-3814. Drop a column family through debug cli tool (apache#1083)
  HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block. (apache#1458)
  HDDS-4316. Upgrade to angular 1.8.0 due to CVE-2020-7676 (apache#1481)
  HDDS-4325. Incompatible return codes from Ozone getconf -confKey (apache#1485). Contributed by Doroszlai, Attila.
  HDDS-4309. Fix inconsistency in recon config keys starting with recon and not ozone (apache#1478)
  HDDS-4310: Ozone getconf broke the compatibility (apache#1475)
  HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager (apache#1460)
  HDDS-4280. Document notable configurations for Recon. (apache#1448)
  HDDS-4156. add hierarchical layout to Chinese doc (apache#1368)
  HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage (apache#1444)
  HDDS-4264. Uniform naming conventions of Ozone Shell Options. (apache#1447)
  HDDS-4271. Avoid logging chunk content in Ozone Insight (apache#1466)
  HDDS-4299. Display Ratis version with ozone version (apache#1464)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Pull request that modifies the build process
Projects
None yet
3 participants