HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block. #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ChenSammi , this PR add judge whether we can be write if bucket space quota enable. Can you help to review this? |
ChenSammi
reviewed
Oct 9, 2020
| @@ -218,6 +219,8 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, | |||
| // update usedBytes atomically. | |||
| omVolumeArgs.getUsedBytes().add(preAllocatedSpace); | |||
| omBucketInfo.getUsedBytes().add(preAllocatedSpace); | |||
| long vol = omVolumeArgs.getUsedBytes().sum(); | |||
| long buk = omBucketInfo.getUsedBytes().sum(); | |||
There was a problem hiding this comment.
Are these two used somewhere?
There was a problem hiding this comment.
Redundancy code, will delete this.
ChenSammi
reviewed
Oct 9, 2020
| long preAllocatedSpace = newLocationList.size() | ||
| * ozoneManager.getScmBlockSize() | ||
| * omKeyInfo.getFactor().getNumber(); | ||
| checkVolumeQuotaInBytes(omVolumeArgs, preAllocatedSpace); | ||
| checkBucketQuotaInBytes(omBucketInfo, preAllocatedSpace); |
There was a problem hiding this comment.
Better check bucket quota before volume quota check.
|
LGTM +1. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Oct 14, 2020
* master: (23 commits) HDDS-4122. Implement OM Delete Expired Open Key Request and Response (apache#1435) HDDS-4336. ContainerInfo does not persist BCSID (sequenceId) leading to failed replica reports (apache#1488) Remove extra serialization from getBlockID (apache#1470) HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests (apache#1436) HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens() (apache#1454) HDDS-4312. findbugs check succeeds despite compile error (apache#1476) HDDS-4311. Type-safe config design doc points to OM HA (apache#1477) HDDS-3814. Drop a column family through debug cli tool (apache#1083) HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block. (apache#1458) HDDS-4316. Upgrade to angular 1.8.0 due to CVE-2020-7676 (apache#1481) HDDS-4325. Incompatible return codes from Ozone getconf -confKey (apache#1485). Contributed by Doroszlai, Attila. HDDS-4309. Fix inconsistency in recon config keys starting with recon and not ozone (apache#1478) HDDS-4310: Ozone getconf broke the compatibility (apache#1475) HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager (apache#1460) HDDS-4280. Document notable configurations for Recon. (apache#1448) HDDS-4156. add hierarchical layout to Chinese doc (apache#1368) HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage (apache#1444) HDDS-4264. Uniform naming conventions of Ozone Shell Options. (apache#1447) HDDS-4271. Avoid logging chunk content in Ozone Insight (apache#1466) HDDS-4299. Display Ratis version with ozone version (apache#1464) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In addition, the current Quota setting does not take effect. HDDS-541 gives all the work needed to perfect Quota.
This PR is a subtask of HDDS-541.
Bucket has implemented increase usedBytes when write, and this PR is based on #1431.
In this PR we judge whether the Bucket can be written when we write the key if the Bucket space quota enable.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3728
How was this patch tested?
ut added