HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage #1444
Conversation
|
R @elek Only migrating |
| * <li>world::rw | ||
| * </ul> | ||
| */ | ||
| final class OzoneAclStorage { |
There was a problem hiding this comment.
Have to duplicate this class because the original one was used by different places. That's why I make this class package-private to make it only useable by codec classes.
There was a problem hiding this comment.
+1, thanks the patch @amaliujia
One comment: I am not sure if we need a separated util classes where we have static toProtobuf and fromProtobuf methods. As we already have an interface which has the responsibility of encode/decode classes (Codec) I would consider moving all encoding/decoding logic to the codec and re-use from there (if necessary).
But this is just my opinion, and I can be convinced.
(As we expect more patches I am fine to merge it as is, but we can continue the discussion...)
|
@elek your suggestion make senses as the new util classes are dedicated to be used by How about let me try to remove util classes in the next PR? This PR is to have a working migration for single proto migration to build consensus around naming convention, how to deal with helpers/util classes. As this PR looks good overall, I will move ~3 proto in each future PR to accelerate migrate process while keep each PR be easier to review. I can address the util class comment in the next PR with more data points there (e.g. 3 more proto migration) |
|
@elek friendly ping~ WDYT on the idea in my previous reply? |
|
Sorry, I was busy at apachecon last week. Sure, fine to do it later. it's just an opinion and fine to follow it in next PRs. Let me merge it now. |
* master: (23 commits) HDDS-4122. Implement OM Delete Expired Open Key Request and Response (apache#1435) HDDS-4336. ContainerInfo does not persist BCSID (sequenceId) leading to failed replica reports (apache#1488) Remove extra serialization from getBlockID (apache#1470) HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests (apache#1436) HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens() (apache#1454) HDDS-4312. findbugs check succeeds despite compile error (apache#1476) HDDS-4311. Type-safe config design doc points to OM HA (apache#1477) HDDS-3814. Drop a column family through debug cli tool (apache#1083) HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block. (apache#1458) HDDS-4316. Upgrade to angular 1.8.0 due to CVE-2020-7676 (apache#1481) HDDS-4325. Incompatible return codes from Ozone getconf -confKey (apache#1485). Contributed by Doroszlai, Attila. HDDS-4309. Fix inconsistency in recon config keys starting with recon and not ozone (apache#1478) HDDS-4310: Ozone getconf broke the compatibility (apache#1475) HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager (apache#1460) HDDS-4280. Document notable configurations for Recon. (apache#1448) HDDS-4156. add hierarchical layout to Chinese doc (apache#1368) HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage (apache#1444) HDDS-4264. Uniform naming conventions of Ozone Shell Options. (apache#1447) HDDS-4271. Avoid logging chunk content in Ozone Insight (apache#1466) HDDS-4299. Display Ratis version with ozone version (apache#1464) ...
What changes were proposed in this pull request?
As a following effort, try to move
PrefixInfoand other necessary classes tointerface-stroageWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4242
How was this patch tested?
Unit Test