HDDS-4264. Uniform naming conventions of Ozone Shell Options. #1447
Conversation
|
Hi @adoroszlai @elek @ChenSammi Could you help review this PR? |
|
+1 on unifying the name convention. Though not sure which name convention is better :) Would also want to hear suggestions from @adoroszlai |
captainzmc
force-pushed
the
unified-commond
branch
2 times, most recently
from
dbe635b
to
78dc880
Compare
|
@captainzmc you might try |
|
Thanks for working on this @captainzmc. Can you please resolve conflict with latest master when you get a chance? |
captainzmc
force-pushed
the
unified-commond
branch
from
78dc880
to
147b1d8
Compare
|
Thanks for @adoroszlai 's reminding. I have solved the conflict. This PR can continue to be reviewed. |
There was a problem hiding this comment.
(big) +1
Thanks for the fix @captainzmc
I really like that we started to follow the standard convention. (I use a lot of shell tools and camel case parameters always annoyed me).
And change seems to be backward compatible / safe (old aliases still work)
* master: (23 commits) HDDS-4122. Implement OM Delete Expired Open Key Request and Response (apache#1435) HDDS-4336. ContainerInfo does not persist BCSID (sequenceId) leading to failed replica reports (apache#1488) Remove extra serialization from getBlockID (apache#1470) HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests (apache#1436) HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens() (apache#1454) HDDS-4312. findbugs check succeeds despite compile error (apache#1476) HDDS-4311. Type-safe config design doc points to OM HA (apache#1477) HDDS-3814. Drop a column family through debug cli tool (apache#1083) HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block. (apache#1458) HDDS-4316. Upgrade to angular 1.8.0 due to CVE-2020-7676 (apache#1481) HDDS-4325. Incompatible return codes from Ozone getconf -confKey (apache#1485). Contributed by Doroszlai, Attila. HDDS-4309. Fix inconsistency in recon config keys starting with recon and not ozone (apache#1478) HDDS-4310: Ozone getconf broke the compatibility (apache#1475) HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager (apache#1460) HDDS-4280. Document notable configurations for Recon. (apache#1448) HDDS-4156. add hierarchical layout to Chinese doc (apache#1368) HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage (apache#1444) HDDS-4264. Uniform naming conventions of Ozone Shell Options. (apache#1447) HDDS-4271. Avoid logging chunk content in Ozone Insight (apache#1466) HDDS-4299. Display Ratis version with ozone version (apache#1464) ...
What changes were proposed in this pull request?
Current Shell command of Ozone, some use hump connection, some use '-' connection. We need to unify the naming conventions.
See the usage documentation of Picocli, which use '-' connection more often.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4264
How was this patch tested?
UT has been fixed.