Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4299. Display Ratis version with ozone version #1464

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

elek
Copy link
Member

@elek elek commented Oct 1, 2020

What changes were proposed in this pull request?

During the development Ozone uses snapshot releases from Ratis. It can be useful to print out the exact version of the used Ratis as part of the output of "ozone version".

Ratis versions are part of the jar files since RATIS-1050

It can make the testing easier, as it's easier to check which Ratis version is used.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4299

How was this patch tested?

 ./bin/ozone version
                  //////////////
               ////////////////////
            ////////     ////////////////
           //////      ////////////////
          /////      ////////////////  /
         /////            ////////   ///
         ////           ////////    /////
        /////         ////////////////
        /////       ////////////////   //
         ////     ///////////////   /////
         /////  ///////////////     ////
          /////       //////      /////
           //////   //////       /////
             ///////////     ////////
               //////  ////////////
               ///   //////////
              /    1.1.0-SNAPSHOT(Denali)

Source code repository git@github.com:apache/hadoop-ozone.git -r b2c6c3b61572bfd9b765f106ab2cf501db55e5e8
Compiled by elek on 2020-10-01T10:35Z
Compiled with protoc 2.5.0
From source with checksum ff92fd89808d10a6ee1dc21db8276427
With Apache Ratis: 1.1.0-11689cd-SNAPSHOT from 11689cd536b05bde323c9c6c6b57a8e82a60b680

Using HDDS 1.1.0-SNAPSHOT
Source code repository git@github.com:apache/hadoop-ozone.git -r b2c6c3b61572bfd9b765f106ab2cf501db55e5e8
Compiled by elek on 2020-10-01T10:34Z
Compiled with protoc 2.5.0
From source with checksum d0e6e752e4d52fb0f05063e16ade73d7

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except leftover ' (and some code duplication).

…RatisVersionInfo.java

Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
@adoroszlai adoroszlai merged commit 8cd86a6 into apache:master Oct 5, 2020
@adoroszlai
Copy link
Contributor

Thanks @elek for the contribution.

errose28 pushed a commit to errose28/ozone that referenced this pull request Oct 6, 2020
errose28 added a commit to errose28/ozone that referenced this pull request Oct 14, 2020
* master: (23 commits)
  HDDS-4122. Implement OM Delete Expired Open Key Request and Response (apache#1435)
  HDDS-4336. ContainerInfo does not persist BCSID (sequenceId) leading to failed replica reports (apache#1488)
  Remove extra serialization from getBlockID (apache#1470)
  HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests (apache#1436)
  HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens() (apache#1454)
  HDDS-4312. findbugs check succeeds despite compile error (apache#1476)
  HDDS-4311. Type-safe config design doc points to OM HA (apache#1477)
  HDDS-3814. Drop a column family through debug cli tool (apache#1083)
  HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block. (apache#1458)
  HDDS-4316. Upgrade to angular 1.8.0 due to CVE-2020-7676 (apache#1481)
  HDDS-4325. Incompatible return codes from Ozone getconf -confKey (apache#1485). Contributed by Doroszlai, Attila.
  HDDS-4309. Fix inconsistency in recon config keys starting with recon and not ozone (apache#1478)
  HDDS-4310: Ozone getconf broke the compatibility (apache#1475)
  HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager (apache#1460)
  HDDS-4280. Document notable configurations for Recon. (apache#1448)
  HDDS-4156. add hierarchical layout to Chinese doc (apache#1368)
  HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage (apache#1444)
  HDDS-4264. Uniform naming conventions of Ozone Shell Options. (apache#1447)
  HDDS-4271. Avoid logging chunk content in Ozone Insight (apache#1466)
  HDDS-4299. Display Ratis version with ozone version (apache#1464)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants