Skip to content

PARQUET-2438: Fixes minMaxSize for BinaryColumnIndexBuilder#1279

Merged
wgtmac merged 2 commits into
apache:masterfrom
ConeyLiu:fixes-min-max-size
Feb 27, 2024
Merged

PARQUET-2438: Fixes minMaxSize for BinaryColumnIndexBuilder#1279
wgtmac merged 2 commits into
apache:masterfrom
ConeyLiu:fixes-min-max-size

Conversation

@ConeyLiu
Copy link
Copy Markdown
Contributor

@ConeyLiu ConeyLiu commented Feb 23, 2024

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

This fixes the minMaxSize calculation for BinaryColumnIndexBuilder since the min/max value can be truncated.

@ConeyLiu
Copy link
Copy Markdown
Contributor Author

@wgtmac @gszadovszky @shangxinli could you help to review this? Thanks a lot.

@wgtmac
Copy link
Copy Markdown
Member

wgtmac commented Feb 26, 2024

Could you rebase it?

@ConeyLiu
Copy link
Copy Markdown
Contributor Author

rebased

@wgtmac wgtmac merged commit 87ee1b3 into apache:master Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants