PARQUET-2438: Fixes minMaxSize for BinaryColumnIndexBuilder#1279
Merged
Conversation
Contributor
Author
|
@wgtmac @gszadovszky @shangxinli could you help to review this? Thanks a lot. |
wgtmac
reviewed
Feb 23, 2024
gszadovszky
approved these changes
Feb 23, 2024
wgtmac
approved these changes
Feb 23, 2024
Member
|
Could you rebase it? |
4ae5b7e to
720b28f
Compare
Contributor
Author
|
rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
Tests
Commits
from "How to write a good git commit message":
Style
mvn spotless:apply -Pvector-pluginsDocumentation
This fixes the
minMaxSizecalculation for BinaryColumnIndexBuilder since the min/max value can be truncated.