PARQUET-151: Skip writing _metadata file in case of no footers since schema cannot be determined.#205
Closed
saucam wants to merge 1 commit intoapache:masterfrom
Closed
PARQUET-151: Skip writing _metadata file in case of no footers since schema cannot be determined.#205saucam wants to merge 1 commit intoapache:masterfrom
saucam wants to merge 1 commit intoapache:masterfrom
Conversation
…schema cannot be determined. This fixes npe seen during mergeFooters in such a case.
For this scenario onus of writing any summary files lies with the caller (It might have some global schema available)
Contributor
|
Looks good to me. Thanks @saucam! |
Author
|
Thanks for the review and the merge @rdblue ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes npe seen during mergeFooters in such a case.
For this scenario onus of writing any summary files lies with the caller (It might have some global schema available) So for example spark does it when persisting empty RDD.