Skip to content

PARQUET-2005: Upgrade thrift to 0.14.1#884

Merged
Fokko merged 3 commits intoapache:masterfrom
gszadovszky:PARQUET-2005
Apr 8, 2021
Merged

PARQUET-2005: Upgrade thrift to 0.14.1#884
Fokko merged 3 commits intoapache:masterfrom
gszadovszky:PARQUET-2005

Conversation

@gszadovszky
Copy link
Copy Markdown
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Copy link
Copy Markdown
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Fokko Driesprong <fokko@driesprong.frl>
@Fokko Fokko merged commit d23a9a7 into apache:master Apr 8, 2021
@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Apr 8, 2021

Thanks @gszadovszky

@dongjoon-hyun
Copy link
Copy Markdown
Member

It's great! Thanks.

sunchao pushed a commit to sunchao/parquet-mr that referenced this pull request Mar 3, 2022
* PARQUET-2005: Upgrade thrift to 0.14.1

* PARQUET-2005: Update thrift version in CI scripts and README

* Update README.md

Co-authored-by: Fokko Driesprong <fokko@driesprong.frl>

Co-authored-by: Fokko Driesprong <fokko@driesprong.frl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants