Skip to content

improve performance for PDAbstractAppearanceHandler.handleBorderBox method #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

improve performance for PDAbstractAppearanceHandler.handleBorderBox method #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...rg/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDAbstractAppearanceHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,13 +527,13 @@ PDRectangle handleBorderBox(PDAnnotationSquareCircle annotation, float lineWidth
float[] rectDifferences = annotation.getRectDifferences();
if (rectDifferences.length == 0)
{
borderBox = getPaddedRectangle(getRectangle(), lineWidth / 2);
PDRectangle rect = getRectangle();
borderBox = getPaddedRectangle(rect, lineWidth / 2);
// the differences rectangle
annotation.setRectDifferences(lineWidth / 2);
annotation.setRectangle(addRectDifferences(getRectangle(), annotation.getRectDifferences()));
annotation.setRectangle(addRectDifferences(rect, annotation.getRectDifferences()));
// when the normal appearance stream was generated BBox and Matrix have been set to the
// values of the original /Rect. As the /Rect was changed that needs to be adjusted too.
PDRectangle rect = getRectangle();
PDAppearanceStream appearanceStream = annotation.getNormalAppearanceStream();
AffineTransform transform =
AffineTransform.getTranslateInstance(-rect.getLowerLeftX(), -rect.getLowerLeftY());
Expand Down