Skip to content

fix comments in IOUtils.unmap #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix comments in IOUtils.unmap #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions io/src/main/java/org/apache/pdfbox/io/IOUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ public static IOException closeAndLogException(Closeable closeable, Logger logge

/**
* Unmap memory mapped byte buffers. This is a hack waiting for a proper JVM provided solution expected in java 10
* https://bugs.openjdk.java.net/browse/JDK-4724038 The issue here is that even when closed, memory mapped byte
* buffers hold a lock on the underlying file until GC is executes and this in turns result in an error if the user
* <a href="https://bugs.openjdk.java.net/browse/JDK-4724038">Add unmap method to MappedByteBuffer</a>. The issue here is that even when closed, memory mapped byte
* buffers hold a lock on the underlying file until GC is executing and this in turns result in an error if the user
* tries to move or delete the file.
*
* @param buf the buffer to be unmapped
Expand Down