Skip to content

remove unneeded checks in BruteForceParser.bfSearchForTrailer #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

remove unneeded checks in BruteForceParser.bfSearchForTrailer #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BruteForceParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,23 +417,17 @@ private boolean bfSearchForTrailer(COSDictionary trailer) throws IOException
{
trailer.setItem(COSName.ROOT, rootObj);
trailer.setItem(COSName.INFO, infoObj);
if (trailerDict.containsKey(COSName.ENCRYPT))
COSObject encObj = trailerDict.getCOSObject(COSName.ENCRYPT);
// check if the dictionary can be dereferenced
// TODO check if the dictionary is an encryption dictionary?
if (encObj != null && encObj.getObject() instanceof COSDictionary)
{
COSObject encObj = trailerDict.getCOSObject(COSName.ENCRYPT);
// check if the dictionary can be dereferenced
// TODO check if the dictionary is an encryption dictionary?
if (encObj != null && encObj.getObject() instanceof COSDictionary)
{
trailer.setItem(COSName.ENCRYPT, encObj);
}
trailer.setItem(COSName.ENCRYPT, encObj);
}
if (trailerDict.containsKey(COSName.ID))
COSBase idObj = trailerDict.getItem(COSName.ID);
if (idObj instanceof COSArray)
{
COSBase idObj = trailerDict.getItem(COSName.ID);
if (idObj instanceof COSArray)
{
trailer.setItem(COSName.ID, idObj);
}
trailer.setItem(COSName.ID, idObj);
}
return true;
}
Expand Down