close streams in TestCOSIncrement #340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks but both are closed when done (see parameter description in javadoc). |
Author
Okay. I see where a stream to load font is closed. |
Author
|
I checked all cases for PDDocument.saveIncremental method. For each case the stream was closed outside. |
Contributor
|
Thank you, I see that this was changed in https://issues.apache.org/jira/browse/PDFBOX-4321 , however the javadoc and the test weren't all fixed, I'll do that. |
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Nov 18, 2025
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/3.0@1929835 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.