Add AWS GOV partitions support #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyCanCode
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
Contributor
|
The changes look good, but if we can't test CN I wonder if we can keep it blocked until somebody is able to test it? |
Contributor
Author
Sounds good to me. I will update this PR to keep CN blocked. |
MonkeyCanCode
changed the title
eric-maynard
approved these changes
Feb 25, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable AWS GOV partitions support. This is only tested with AWS GOV partition and not CN partition (as I don't have an AWS account with CN partition to test with, but it should be similar).
The existed code already supported/worked with AWS GOV region. The only catch is as those are non-default partitions, the STS endpoint is different. By default, STS requests are made with default partition. Thus, to use AWS GOV partition (as well as CN partition), region info must be set on the catalog.