[OpenAPI Modification] Return created objects #2603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CatalogRole to return 204 (No Content) on success
adutra
reviewed
Sep 18, 2025
Contributor
adutra
left a comment
adutra
left a comment
There was a problem hiding this comment.
The changes LGTM but you will need to adapt some of the regtests.
dimas-b
reviewed
Sep 18, 2025
spec/polaris-management-service.yml
Outdated
| $ref: "#/components/schemas/RevokeGrantRequest" | ||
| responses: | ||
| 201: | ||
| 204: |
Contributor
There was a problem hiding this comment.
This is technically a breaking change per our current "evolution" approach: https://polaris.apache.org/releases/1.0.1/evolution/#semantic-versioning
The change itself is meaningful, but if we make it, I suppose we'd have to do a major version bump (which is ok from my POV)..
Contributor
Author
There was a problem hiding this comment.
Removed as per ML - and will introduce it separately.
adnanhemani
changed the title
adutra
previously approved these changes
Sep 19, 2025
Contributor
adutra
left a comment
adutra
left a comment
There was a problem hiding this comment.
LGTM. I wasn't too worried about the 201 -> 204 change, but I agree that it's better to leave this change out.
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
reviewed
Sep 19, 2025
HonahX
previously approved these changes
Sep 19, 2025
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
LGTM! +1 on adding a line in the CHANGELOG to reveal this. We should also update our python cli to print the entity, we can do that in a follow-up : )
adnanhemani
dismissed stale reviews from HonahX, flyrain, and adutra
via
5f27979
dimas-b
approved these changes
Sep 19, 2025
HonahX
approved these changes
Sep 20, 2025
singhpk234
approved these changes
Sep 21, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Contributor
adnanhemani
deleted the
ahemani/open-api-changes-return-obj-after-create
branch
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* Always propagate non-credential properties from AccessConfig to clients (apache#2615) * Always propagate non-credential properties from AccessConfig to clients This change builds on top of apache#2589 and further prepares Polaris code to support non-STS S3 implementations for apache#2589. For S3 implementations that do have STS, this change enables clients to run with local credentials (no credential vending) and still receive endpoint configuration from the catalog. * Call `SupportsCredentialDelegation.getAccessConfig()` on all relevant create/load requests (previously it was called only when `vended-credentials` was requested * Always sent `AccessConfig.extraProperties()` to clients * Expose credentials to clients only when the `vended-credentials` access delegation mode is requested. * There is not client-visible behaviour change for implementations of `PolarisStorageIntegration` that do not produce "extra" `AccessConfig` properties. * [OpenAPI Modification] Return created objects (apache#2603) As per the ML thread [here](https://lists.apache.org/thread/q7q0rrsmw5gcqv30g4hr9ffq3gtr72yk), this PR introduces the change to return all objects that are created within their respective API calls. * chore(docs): reorganize getting-started section (apache#2611) * fix(deps): update dependency org.assertj:assertj-core to v3.27.6 (apache#2651) * fix: fix broken markdown-link-check CI job after apache#2611 got merged (apache#2655) * Release artifacts should use dlcdn.apache.org (signature and checksum must refer downloads.apache.org) (apache#2647) * docs: Update S3 getting started guides (apache#2652) * fix(deps): update dependency com.google.cloud:google-cloud-storage-bom to v2.58.0 (apache#2660) * fix(deps): update dependency org.apache.spark:spark-sql_2.12 to v3.5.7 (apache#2659) * fix(deps): update dependency org.apache.spark:spark-sql_2.12 to v3.5.7 (apache#2658) * Fix Issue 2024 for Rendering Blockquotes (apache#2656) * Fix Issue 2024 for Rendering Blockquotes * Small fix for URLs * Update license * Last merged commit fcb6b33 --------- Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com> Co-authored-by: Adnan Hemani <adnan.h@berkeley.edu> Co-authored-by: Artur Rakhmatulin <artur.rakhmatulin@gmail.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: JB Onofré <jbonofre@apache.org> Co-authored-by: Adam Christian <105929021+adam-christian-software@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the ML thread here, this PR introduces the change to return all objects that are created within their respective API calls.
Additionally, therevokeGrantFromCatalogRoleAPI will now return 204 (No Content) on a successful call rather than 201 (Created).