Skip to content

Conversation

@MonkeyCanCode
Copy link
Contributor

@MonkeyCanCode MonkeyCanCode commented Oct 13, 2025

This PR bumps the version for poetry and removed the fixed version for virtualenv. Also, it matches the version for openapi-generator-cli.

We used fixed version for poetry and virtualenv due to python-poetry/poetry#10504 (comment). This is fixed via pypa/virtualenv#2944

We used fixed version of openapi-generator-cli due to #1822 (comment). Even we dropped support for python 3.9 via #2795, I noticed there are more issues with when using version of openapi-generator-cli. After some debugging, this is due to #2801. Thus the latest working version with current code is 7.12.0. Once #2801 is merged and bump the openapi spec version from 3.0.3 to 3.1.1, we can then bump up the version again.

@MonkeyCanCode MonkeyCanCode reopened this Oct 13, 2025
@github-project-automation github-project-automation bot moved this from Done to PRs In Progress in Basic Kanban Board Oct 13, 2025
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Thanks for working on this! Some small comments

pyiceberg = "==0.10.0"
pre-commit = "==4.3.0"
openapi-generator-cli = "==7.15.0"
openapi-generator-cli = "==7.12.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good if we upgrade the generator version along with the one we used in java:

openapi-generator = { id = "org.openapi.generator", version = "7.12.0" }

Let's keep it 7.12 for this PR : )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing the generator version in gradle (didn't saw that earlier), but yeah, it appear both are 7.12.0 (which the latest working version unless we will do 3.1.1)

Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Oct 14, 2025
@MonkeyCanCode MonkeyCanCode merged commit 27a499d into apache:main Oct 14, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants