-
Notifications
You must be signed in to change notification settings - Fork 320
Bump version for python deps #2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Thanks for working on this! Some small comments
| pyiceberg = "==0.10.0" | ||
| pre-commit = "==4.3.0" | ||
| openapi-generator-cli = "==7.15.0" | ||
| openapi-generator-cli = "==7.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be good if we upgrade the generator version along with the one we used in java:
polaris/gradle/libs.versions.toml
Line 115 in dbc21a3
| openapi-generator = { id = "org.openapi.generator", version = "7.12.0" } |
Let's keep it 7.12 for this PR : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing the generator version in gradle (didn't saw that earlier), but yeah, it appear both are 7.12.0 (which the latest working version unless we will do 3.1.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR bumps the version for poetry and removed the fixed version for virtualenv. Also, it matches the version for openapi-generator-cli.
We used fixed version for poetry and virtualenv due to python-poetry/poetry#10504 (comment). This is fixed via pypa/virtualenv#2944
We used fixed version of openapi-generator-cli due to #1822 (comment). Even we dropped support for python 3.9 via #2795, I noticed there are more issues with when using version of openapi-generator-cli. After some debugging, this is due to #2801. Thus the latest working version with current code is
7.12.0. Once #2801 is merged and bump the openapi spec version from3.0.3to3.1.1, we can then bump up the version again.