Skip to content

Conversation

@XN137
Copy link
Contributor

@XN137 XN137 commented Nov 3, 2025

as per ML decision the deprecated eclipselink backend is being removed in the next version:

https://lists.apache.org/thread/16bj5kngf2kfhqv3noxwfm7h9wlzvhyv

as per ML decision the deprecated eclipselink backend is being removed
in the next version:

https://lists.apache.org/thread/16bj5kngf2kfhqv3noxwfm7h9wlzvhyv

### Breaking changes

- The EclipseLink Persistence implementation has been completely removed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file has the only remaining mention of eclipselink related things:

➜  polaris git:(remove-eclipselink) git grep -i 'persistence.xml'

➜  polaris git:(remove-eclipselink) git grep -i 'eclipse.*link'
CHANGELOG.md:- The EclipseLink Persistence implementation has been completely removed.
CHANGELOG.md:- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
site/content/downloads/_index.md:  - The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@XN137 XN137 marked this pull request as ready for review November 3, 2025 10:38
return List.of(
new TestResourceEntry(
PostgresRelationalJdbcLifeCycleManagement.class,
Map.of(INIT_SCRIPT, "org/apache/polaris/admintool/init.sql")));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out the init script (which creates 2 more databases) isnt needed at all by current tests

Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too ! can you please double confirm all the getting started works ?

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 3, 2025
Copy link
Contributor

@adam-christian-software adam-christian-software left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for doing this!

@dimas-b
Copy link
Contributor

dimas-b commented Nov 3, 2025

Given ML discussion and GH approvals for far, I'm merging this PR... If we hit any issues with getting-started guides, let's fix-forward.

@dimas-b dimas-b merged commit a366d73 into apache:main Nov 3, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 3, 2025
@XN137 XN137 deleted the remove-eclipselink branch November 4, 2025 06:29
@adutra
Copy link
Contributor

adutra commented Nov 6, 2025

Fixes #2610

snazy added a commit to snazy/polaris that referenced this pull request Nov 20, 2025
* Pass AccessConfig into FileIOFactory (apache#2937)

it should not be the responsibility of the `FileIOFactory` to know how
to infer the `AccessConfig`

* Remove EclipseLink Persistence Backend (apache#2963)

as per ML decision the deprecated eclipselink backend is being removed
in the next version:

https://lists.apache.org/thread/16bj5kngf2kfhqv3noxwfm7h9wlzvhyv

* feat: Improve PolarisAdminTool default output (apache#2961)

* feat: Improve PolarisAdminTool default output

* feat: Improve PolarisAdminTool default output

* Add Polaris Community Meeting 2025-10-30 (apache#2973)

* Remove legacy management endpoints (apache#2276)

* Build/nit: cache output of `generatedMarkdownDocs` (apache#2967)

`(Java)Exec` tasks are not cacheable by default, as annotated with `@DisableCachingByDefault`.
Adding an `outputs.cacheIf { true }` enables caching on those tasks.

* Build: Helper to get effective ASF project metadata (apache#2969)

This change "bundles" the information of `AsfProject` and the `PublishingHelperExtensions`, which is what the code in `configurePom.kt` did. Bundling these objects allows other consumers, like CycloneDX SBOM generation, to access that same information without having to query remote systems (whimsey.apache.org) again.

* Alternative, concise PR template (apache#2945)

This PR proposes an alternative PR template that is much shorter, and removes all the redundant claims.

It also links to the contribution guidelines for further guidance.

* Add docs how to add `Server` header to HTTP responses (apache#2941)

* Prefer PolarisPrincipal over SecurityContext (apache#2932)

The general idea is that `SecurityContext` comes from `jakarta.ws.rs` and
there is no reason for non-REST related classes to rely on those details.
Instead, once preprocessing of a REST-request has inferred the
`PolarisPrincipal` all inner/core code should rely on only that.

Note that this simplifies a bunch of tests that had to create their own
`SecurityContext` around the principal that they wanted to use, thus
having to decide how to implement `isUserInRole` and the other methods.

* Last merged commit f934443

---------

Co-authored-by: Christopher Lambert <xn137@gmx.de>
Co-authored-by: Yong Zheng <yongzheng0809@gmail.com>
Co-authored-by: JB Onofré <jbonofre@apache.org>
Co-authored-by: Alexandre Dutra <adutra@apache.org>
Co-authored-by: fivetran-arunsuri <103934371+fivetran-arunsuri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants