Skip to content

Conversation

@snazy
Copy link
Member

@snazy snazy commented Nov 24, 2025

The PR #2819 accidentally removed the executable POSIX file permission, assuming that not explicity setting the attributes via filePermissions retains the file-system 'x' permission.

This change updates the logic to explicitly check the owner-executable bit and uses 755 or 644 respectively for each individual file in the archive.

@snazy snazy added this to the 1.3.0 milestone Nov 24, 2025
@snazy snazy requested a review from pingtimeout November 24, 2025 15:11
@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Nov 24, 2025
dimas-b
dimas-b previously approved these changes Nov 24, 2025
@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 24, 2025
The PR apache#2819 accidentally _removed_ the executable POSIX file permission, assuming that not explicity setting the attributes via `filePermissions` retains the file-system 'x' permission.

This change updates the logic to explicitly check the owner-executable bit and uses `755` or `644` respectively for each individual file in the archive.
@snazy snazy merged commit 65218ca into apache:main Nov 24, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 24, 2025
@snazy snazy deleted the fix-x-posix-perm branch November 24, 2025 15:59
pingtimeout pushed a commit to pingtimeout/polaris that referenced this pull request Nov 24, 2025
The PR apache#2819 accidentally _removed_ the executable POSIX file permission, assuming that not explicity setting the attributes via `filePermissions` retains the file-system 'x' permission.

This change updates the logic to explicitly check the owner-executable bit and uses `755` or `644` respectively for each individual file in the archive.
pingtimeout added a commit that referenced this pull request Nov 24, 2025
The PR #2819 accidentally _removed_ the executable POSIX file permission, assuming that not explicity setting the attributes via `filePermissions` retains the file-system 'x' permission.

This change updates the logic to explicitly check the owner-executable bit and uses `755` or `644` respectively for each individual file in the archive.

Co-authored-by: Robert Stupp <snazy@snazy.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants