Fix nullptr after listener consumer closed #510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failed Node.js client test cpp 3.8.0 CI: https://github.com/apache/pulsar-client-node/actions/runs/18549226483/job/52888496279?pr=437
Motivation
Fix a segmentation fault when the consumer is closed.
Root cause:
incomingMessages_ queueis closed.internalListenermethod, which attempts to pop message content from theincomingMessages_ queue.Modifications
incomingMessages_false (indicating no more messages or queue closed). If so, return early.Verifying this change
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)