[fix][broker] Fix partitioned topic auto deletion http request timeout

[oneby-wang]

Fixes #24879

Motivation

Partitioned-topic auto deletion call chain:

1. gc process(invoked on broker0)
2. delete partitioned-topic admin api(invoked on broker0)
3. delete topic-partition-0 admin api(invoked on broker0)

If brokerClient's connectionsPerBroker is 1, then broker0 wait itself to release the connection, the result is timeout. So we check topic-partition-0 existence first to avoid connection pool deadlock.

Modifications

When calling delete partitioned-topic admin api, first check topic partitions existence to avoid calling delete topic admin api by broker itself again, which would help partitioned-topic auto deletion in gc process.

Verifying this change

• Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as (please describe tests).

InactiveTopicDeleteTest#testWhenSubPartitionNotDelete() test method.

pulsar/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java

Lines 113 to 136 in 1ca1797

	@Test
	public void testWhenSubPartitionNotDelete() throws Exception {
	conf.setBrokerDeleteInactiveTopicsMode(InactiveTopicDeleteMode.delete_when_no_subscriptions);
	conf.setBrokerDeleteInactivePartitionedTopicMetadataEnabled(true);
	conf.setBrokerDeleteInactiveTopicsFrequencySeconds(1);
	super.baseSetup();
	final String topic = "persistent://prop/ns-abc/testDeleteWhenNoSubscriptions";
	final TopicName topicName = TopicName.get(topic);
	admin.topics().createPartitionedTopic(topic, 5);
	pulsarClient.newProducer().topic(topic).create().close();
	pulsarClient.newConsumer().topic(topic).subscriptionName("sub").subscribe().close();
	Thread.sleep(2000);
	// Topic should not be deleted
	Assert.assertTrue(admin.topics().getPartitionedTopicList("prop/ns-abc").contains(topic));
	admin.topics().deleteSubscription(topic, "sub");
	Awaitility.await().untilAsserted(() -> {
	// Now the topic should be deleted
	Assert.assertFalse(admin.topics().getPartitionedTopicList("prop/ns-abc").contains(topic));
	});
	}

But the default connectionsPerBroker is 16, which can not reproduce the problem.

pulsar/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminBuilderImpl.java

Lines 48 to 51 in 1ca1797

	public PulsarAdminBuilderImpl() {
	this.conf = new ClientConfigurationData();
	this.conf.setConnectionsPerBroker(16);
	}

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: oneby-wang#8