RANGER-5370:GDS request when denied because of inactive status of the DataSet should have data share details #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DataSet should have data share details Signed-off-by: Ramesh Mani <rmani@apache.org>
kumaab
approved these changes
Oct 14, 2025
kumaab
reviewed
Oct 14, 2025
| LOG.debug("==> GdsDatasetEvaluator.evaluate({}, {}, {})", request, result, projectsToEval); | ||
|
|
||
| if (isActive()) { | ||
| result.addDataset(getName()); |
There was a problem hiding this comment.
Alternatively, result.addDataset(getName()); could move before if loop, this way else part can be avoided.
|
This is not needed any more so closing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change is to have the audits generated why GDS request are denied because of DataSet being inactive or expired. Currently without this fix Data Share details are not in the audit and hence audit filtering / reporting cannot be done when denial happens.
How was this patch tested?
Testing with local vm and docker