Skip to content

Conversation

@mneethiraj
Copy link
Contributor

What changes were proposed in this pull request?

  • updated packaging to include guava library
  • updated installation to support configuration atlas.kafka.offsets.topic.replication.factor, which is needed for docker setup

How was this patch tested?

Verified that tagsync successfully initializes Atlas source.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a ClassNotFoundException issue in Ranger TagSync's Atlas source by adding the missing Guava library dependency and introducing support for configuring Kafka offset topic replication factor needed for Docker environments.

Key Changes:

  • Added Guava library to TagSync's assembly dependencies to resolve ClassNotFoundException
  • Introduced configuration support for atlas.kafka.offsets.topic.replication.factor parameter throughout the installation pipeline

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
distro/src/main/assembly/tagsync.xml Added Guava library dependency to TagSync distribution
tagsync/conf/templates/installprop2xml.properties Added property mapping for Kafka offsets topic replication factor
tagsync/scripts/setup.py Added handling for the new replication factor configuration key
dev-support/ranger-docker/scripts/ranger-tagsync-install.properties Enabled Atlas source and configured replication factor for Docker setup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


# SSL config file name for HTTPS messages to tag destination - Ranger
TAG_DEST_RANGER_SSL_CONFIG_FILENAME =

Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Enabling Atlas source by default in the Docker configuration may cause unexpected behavior for existing setups. Consider documenting this change prominently or providing a comment explaining why this default was changed from 'false' to 'true'.

Suggested change
# NOTE: The default value for TAG_SOURCE_ATLAS_ENABLED has been changed from 'false' to 'true' in this Docker configuration.
# This enables Atlas as a tag source by default, which may cause unexpected behavior for existing setups that do not use Atlas.
# Please review and adjust this setting as needed for your environment.

Copilot uses AI. Check for mistakes.
@mneethiraj mneethiraj merged commit a61d9c0 into apache:master Oct 22, 2025
1 check passed
mneethiraj added a commit that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants