Skip to content

Conversation

@mneethiraj
Copy link
Contributor

What changes were proposed in this pull request?

Ranger admin installation updated to support configurations in install.properties for Kerberized Solr.

How was this patch tested?

Verified that installation sets up the new configurations correctly in ranger-admin-site.xml

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for configuring Kerberized Solr in Ranger admin by introducing new JAAS client configuration properties. The changes enable administrators to specify Kerberos authentication parameters during installation.

Key Changes:

  • Added 8 new JAAS client configuration properties for Kerberos authentication
  • Introduced a conditional property update function that only updates values when non-empty
  • Integrated the new properties into the installation script's property update flow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
security-admin/src/main/resources/conf.dist/ranger-admin-site.xml Added 8 new empty JAAS client configuration properties for Kerberos authentication
security-admin/scripts/setup.sh Added updatePropertyToFilePyIfNotEmpty function and 8 calls to update JAAS configuration properties from install.properties

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@kumaab kumaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, one follow-up question -

does this file https://github.com/apache/ranger/blob/master/security-admin/scripts/install.properties require an update?

@mneethiraj
Copy link
Contributor Author

Changes look good, one follow-up question -

does this file https://github.com/apache/ranger/blob/master/security-admin/scripts/install.properties require an update?

@kumaab - good point. It is not necessary to add the new configurations in security-admin/scripts/install.properties; however, adding to this file can serve as a good reference. I just pushed a commit with this change.

@mneethiraj mneethiraj merged commit 7aa0bf4 into apache:master Oct 24, 2025
2 of 3 checks passed
mneethiraj added a commit that referenced this pull request Oct 24, 2025
…ns for kerberized Solr (#712)

(cherry picked from commit 7aa0bf4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants